Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

[Michael Ellerman]

Fathi Boudra <fathi.boudra@xxxxxxxxxx> writes:

> On 29 June 2017 at 12:01, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>> Fathi Boudra <fathi.boudra@xxxxxxxxxx> writes:
>>
>>> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to
>>> figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation.
>>
>> Can you explain how it fixes the values for cross-compilation?
>
> When pkg-config is invoked in a cross-build environment, it will
> return your sysroot headers path instead of the hardcoded
> -I/usr/include/libmount
>
> For example in my oe environment, when I invoke "pkg-config --cflags
> mount", it returns:
> -I/build/tmp-rpb-glibc/sysroots/hikey/usr/include/libmount

Right, presumably because OE is setting PKG_CONFIG_SYSROOT_DIR etc.

So for folks doing it by hand it doesn't really help with cross
compiling, but I guess it doesn't hurt either.

cheers