Re: [PATCH] mm/zsmalloc: simplify zs_max_alloc_size handling

[Jerome Marchand]

On 06/30/2017 03:24 AM, Minchan Kim wrote:
>> @@ -137,6 +142,8 @@
>>   *  (reason above)
>>   */
>>  #define ZS_SIZE_CLASS_DELTA	(PAGE_SIZE >> CLASS_BITS)
>> +#define ZS_SIZE_CLASSES	DIV_ROUND_UP(ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE, \
>> +				     ZS_SIZE_CLASS_DELTA)
> 
> #define ZS_SIZE_CLASSES	(DIV_ROUND_UP(ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE, \
> 				     ZS_SIZE_CLASS_DELTA) + 1)
> 
> 
> I think it should add +1 to cover ZS_MIN_ALLOC_SIZE.

Yes, obviously. Sorry about that.

> Otherwise, looks good to me.
> 
> Thanks.
>

Attachment: signature.asc
Description: OpenPGP digital signature