Re: [PATCH 0/2] Follow-up on "ARM: Fix dma_alloc_coherent() and friends for NOMMU"
From: Vladimir Murzin
Date: Fri Jun 30 2017 - 08:03:27 EST
On 30/06/17 12:36, Benjamin Gaignard wrote:
> 2017-06-28 11:16 GMT+02:00 Vladimir Murzin <vladimir.murzin@xxxxxxx>:
>> These two patches are folloups on "[PATCH v6 0/7] ARM: Fix
>> dma_alloc_coherent() and friends for NOMMU" which has been partly
>> merged in [1]. PATCH 1/2 is done per Christoph's suggestion [2] to
>> eliminate duplication in dma-noop.c. PATCH 2/2 is fixup for ARM's dma
>> operations for NOMMU due to aforementioned change.
>>
>> @Benjamin, your Tested-by for ARM bits would be very appretiated!
>
> I have been able to test on stm32f4 with drm/kms drivers which is
> calling dma_alloc_coherent
> and modetest doing mmap and it is working fine.
>
> tested-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
>
Great thanks!
Vladimir
>>
>> @Christoph, in case you decide to queue PATCH 1/2, can you put it
>> before "ARM: NOMMU: Introduce dma operations for noMMU", so transition
>> to the new dma operations won't break bisectability.
>>
>> [1] git://git.infradead.org/users/hch/dma-mapping.git for-next
>> [2] https://www.spinics.net/lists/arm-kernel/msg590587.html
>>
>> Cc: Steven Miao <realmz6@xxxxxxxxx>
>> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> Cc: Michal Simek <monstr@xxxxxxxxx>
>> Cc: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
>> Cc: Rich Felker <dalias@xxxxxxxx>
>> Cc: Chris Zankel <chris@xxxxxxxxxx>
>> Cc: Max Filippov <jcmvbkbc@xxxxxxxxx>
>>
>> Thanks!
>>
>> Vladimir Murzin (2):
>> drivers: dma-mapping: allow dma_common_mmap() for NOMMU
>> fixup: ARM: NOMMU: Introduce dma operations for noMMU
>>
>> arch/arm/mm/dma-mapping-nommu.c | 18 ------------------
>> arch/blackfin/Kconfig | 1 +
>> arch/m32r/Kconfig | 1 +
>> arch/m68k/Kconfig | 1 +
>> arch/microblaze/Kconfig | 1 +
>> arch/sh/Kconfig | 1 +
>> arch/xtensa/Kconfig | 1 +
>> drivers/base/dma-mapping.c | 4 ++--
>> 8 files changed, 8 insertions(+), 20 deletions(-)
>>
>> --
>> 2.0.0
>>
>
>
>