Re: "mm: use early_pfn_to_nid in page_ext_init" broken on some configurations?

[Michal Hocko]

On Fri 30-06-17 17:42:24, Michal Hocko wrote:
[...]
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 16532fa0bb64..894697c1e6f5 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1055,6 +1055,7 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist,
>  	!defined(CONFIG_HAVE_MEMBLOCK_NODE_MAP)
>  static inline unsigned long early_pfn_to_nid(unsigned long pfn)
>  {
> +	BUILD_BUG_ON(!IS_ENABLED(CONFIG_NUMA));

Err, this should read BUILD_BUG_ON(IS_ENABLED(CONFIG_NUMA)) of course

>  	return 0;
>  }
>  #endif

-- 
Michal Hocko
SUSE Labs