Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure

[Gustavo A. R. Silva]

Quoting Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>:

> On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote:
>
> > Print error message on platform_get_irq failure before return.
> >
> > Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> > ---
> > Changes in v2:
> > Print the return value of platform_get_irq on failure.
> >
> > drivers/ata/pata_imx.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c
> > index d4caa23..66fb1ab 100644
> > --- a/drivers/ata/pata_imx.c
> > +++ b/drivers/ata/pata_imx.c
> > @@ -132,9 +132,10 @@ static int pata_imx_probe(struct platform_device *pdev)
> > 	int ret;
> >
> > 	irq = platform_get_irq(pdev, 0);
> > -	if (irq < 0)
> > +	if (irq < 0) {
> > +		dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq);
> > 		return irq;
> > -
> > +	}
>
>    Removing empty line here doesn't seem a good idea...

Oh yeah, I agree.
I'll send v3 shortly.

Thanks!
--
Gustavo A. R. Silva