Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe()

[MyungJoo Ham]

On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:
> Hi,
>
> On 2017ë 06ì 30ì 16:22, Gustavo A. R. Silva wrote:
>> Print and propagate the return value of platform_get_irq on failure.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
>> ---
>>  drivers/devfreq/tegra-devfreq.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
>> index 214fff9..ae71215 100644
>> --- a/drivers/devfreq/tegra-devfreq.c
>> +++ b/drivers/devfreq/tegra-devfreq.c
>> @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
>>       }
>>
>>       irq = platform_get_irq(pdev, 0);
>> -     if (irq <= 0) {
>> -             dev_err(&pdev->dev, "Failed to get IRQ\n");
>> -             return -ENODEV;
>> +     if (irq < 0) {
>> +             dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
>> +             return irq;
>>       }
>>
>>       platform_set_drvdata(pdev, tegra);
>>
>
> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>

>
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics



-- 
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics