Re: [PATCH 16/21] x86/intel_rdt/cqm: Add mount,umount support

[Thomas Gleixner]

On Mon, 26 Jun 2017, Vikas Shivappa wrote:
>  
>  	list_for_each_entry_safe(rdtgrp, tmp, &rdt_all_groups, rdtgroup_list) {
> +		/* Free any child rmids */
> +		llist = &rdtgrp->crdtgrp_list;
> +		list_for_each_entry_safe(sentry, stmp, llist, crdtgrp_list) {
> +			free_rmid(sentry->rmid);
> +			list_del(&sentry->crdtgrp_list);
> +			kfree(sentry);
> +		}

I'm pretty sure, that I've seen exactly this code sequence already. Please
create a helper instead of copying stuff over and over.

Thanks,

	tglx