Re: [PATCH] zram: constify attribute_group structures.

From: Sergey Senozhatsky
Date: Mon Jul 03 2017 - 05:00:45 EST


On (07/03/17 11:43), Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 8293 841 4 9138 23b2 drivers/block/zram/zram_drv.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 8357 777 4 9138 23b2 drivers/block/zram/zram_drv.o

sorry, what exactly is the improvement here?
we grew .text bigger, why should we be happy about it?

-ss