Re: [PATCH v2 05/19] media: camss: Add CSID files

From: Todor Tomov
Date: Mon Jul 03 2017 - 10:11:41 EST


Hello Hans,

Thank you for the review.

On 07/03/2017 01:49 PM, Hans Verkuil wrote:
> On 06/19/2017 04:48 PM, Todor Tomov wrote:
>> These files control the CSID modules which handle the protocol and application
>> layer of the CSI2 receivers.
>>
>> Signed-off-by: Todor Tomov <todor.tomov@xxxxxxxxxx>
>> ---
>> drivers/media/platform/qcom/camss-8x16/csid.c | 1072 +++++++++++++++++++++++++
>> drivers/media/platform/qcom/camss-8x16/csid.h | 82 ++
>> 2 files changed, 1154 insertions(+)
>> create mode 100644 drivers/media/platform/qcom/camss-8x16/csid.c
>> create mode 100644 drivers/media/platform/qcom/camss-8x16/csid.h
>>
>> diff --git a/drivers/media/platform/qcom/camss-8x16/csid.c b/drivers/media/platform/qcom/camss-8x16/csid.c
>> new file mode 100644
>> index 0000000..c637d78
>> --- /dev/null
>> +++ b/drivers/media/platform/qcom/camss-8x16/csid.c
>> @@ -0,0 +1,1072 @@
>> +/*
>> + * csid.c
>> + *
>> + * Qualcomm MSM Camera Subsystem - CSID Module
>> + *
>> + * Copyright (c) 2011-2015, The Linux Foundation. All rights reserved.
>> + * Copyright (C) 2015-2016 Linaro Ltd.
>
> 2016 -> 2017
>
> This should probably be done elsewhere as well.

Yes, I'll fix it here and on all other places.

>
> Regards,
>
> Hans

--
Best regards,
Todor Tomov