Re: [PATCH v2 1/2] ACPI: SPCR: Use access width to determine mmio usage

From: Greg Kroah-Hartman
Date: Tue Jul 04 2017 - 03:23:03 EST


On Mon, Jul 03, 2017 at 11:44:30PM +0200, Rafael J. Wysocki wrote:
> On Mon, Jul 3, 2017 at 11:33 PM, Loc Ho <lho@xxxxxxx> wrote:
> > The current SPCR code does not check the access width of the mmio, and
> > uses a default of 8bit register accesses. This prevents devices that
> > only do 16 or 32bit register accesses from working. By simply checking
> > this field and setting the mmio string appropriately, this issue can be
> > corrected. To prevent any legacy issues, the code will default to 8bit
> > accesses if the value is anything but 16 or 32.
> >
> > Signed-off-by: Loc Ho <lho@xxxxxxx>
> > [Re-send as single patch set]
> > Signed-off-by: Jon Mason <jon.mason@xxxxxxxxxxxx>
>
> Greg, Aleksey, any objections here?
>
> If not, I'll route this through the ACPI tree.

No objections from me for either of these patches:
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>