Re: [PATCH] x86/platform/uv/BAU: minor cleanup, make some local functions static

[Dou Liyang]

Hi Thomas,

At 07/04/2017 03:19 PM, Thomas Gleixner wrote:
> On Tue, 4 Jul 2017, Dou Liyang wrote:
> > At 07/03/2017 10:22 PM, Colin King wrote:
> > > -int normal_busy(struct bau_control *bcp)
> > > +static int normal_busy(struct bau_control *bcp)
> >
> > In my opinion, there is no need to mark *normal_busy* static, remove it
> > directly.
> >
> > the commit c5d35d399e68(x86/UV2: Work around BAU bug) add it to
> > handle_uv2_busy(), but the handle_uv2_busy() is rewritten now. the
> > normal_busy is unused, can be remove.
>
> Correct.
>
> > By the way, there are also an other function named
> > uv_bau_message_interrupt() can be remove.
>
> Not so much.
>
> # git grep uv_bau_message_interrupt arch/x86/
> arch/x86/entry/entry_64.S:apicinterrupt3 UV_BAU_MESSAGE                 uv_bau_message_intr1            uv_bau_message_interrupt
> arch/x86/platform/uv/tlb_uv.c:void uv_bau_message_interrupt(struct pt_regs *regs)

Oops, Indeed! you are right. ;)

Thanks,

	dou.

> Thanks,
>
> 	tglx