Re: [v2] wlcore: add missing nvs file name info for wilink8
From: Tony Lindgren
Date: Tue Jul 04 2017 - 04:19:30 EST
* Reizer, Eyal <eyalr@xxxxxx> [170703 23:58]:
> When working with wl18xx the nvs file is used for defining an alternate
> mac address and override the default mac address that is stored inside
> the wl18xx chip.
> The following commits:
> c815fde wlcore: spi: Populate config firmware data
> d776fc8 wlcore: sdio: Populate config firmware data
> Populated the nvs entry for wilink6 and wilink7 only while it is
> still needed for wilink8 as well.
> This broke user space backward compatibility when upgrading from older
> kernels, as the alternate mac address would not be read from the nvs that is
> already present in the file system (lib/firmware/ti-connectivity/wl1271-nvs.bin)
> causing mac address change of the wlan interface.
> This patch fix this and update the structure field with the same default nvs file
> name that has been used before.
I think more checks on the nvs file being used are needed to avoid other
nasty issues, see the comments I just made in the earlier version of this