Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

From: Andy Shevchenko
Date: Tue Jul 04 2017 - 06:06:26 EST

Next message: Lorenzo Pieralisi: "Re: [PATCH v3 2/2] acpi/iort: numa: Add numa node mapping for smmuv3 devices"
Previous message: Geert Uytterhoeven: "[PATCH] genirq: Force inlining of __irq_startup_managed to prevent build failure"
In reply to: Charles Keepax: "Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h"
Next in thread: Masahiro Yamada: "Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, 2017-07-04 at 12:53 +0900, Masahiro Yamada wrote:
> Some of include directives in include/linux/gpio/driver.h are
> unneeded because the header does not need to know the content of
> struct device, irq_chip, etc.ÂÂJust declare they are structures.
>
> On the other hand, <linux/irqhandler.h> and <linux/spinlock_types.h>
> turned out to be necessary for irq_flow_handler_t and spinlock_t,
> respectively.
>
> Each driver should include what it needs without relying on what is
> implicitly included from <linux/gpio/driver.h>.ÂÂThis will cut down
> unnecessary header parsing.

If Linus is okay with the following proposal I would rather go with it,
i.e. logical split the series to

1. Fix IRQ related headers inclusion
2. Fix pinconf-generic.h inclusion
3. Fix OF headers inclusion (btw, of_gpio.h is not enough there?)

In any case take my tag

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

for the drivers I have been involved into development of:

Âdrivers/gpio/gpio-dwapb.cÂÂÂÂÂÂÂ |Â 1 +
Âdrivers/gpio/gpio-intel-mid.cÂÂÂ |Â 2 ++
Âdrivers/gpio/gpio-lynxpoint.cÂÂÂ |Â 2 ++
Âdrivers/gpio/gpio-merrifield.cÂÂ |Â 4 ++++
Âdrivers/gpio/gpio-pca953x.cÂÂÂÂÂ |Â 1 +
Âdrivers/gpio/gpio-wcove.cÂÂÂÂÂÂÂ |Â 2 ++

And

Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

for

Âdrivers/gpio/gpiolib-acpi.cÂÂÂÂÂ |Â 1 +

>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
>
> Âdrivers/gpio/gpio-104-dio-48e.cÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-104-idi-48.cÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-104-idio-16.cÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-altera-a10sr.c |ÂÂ2 ++
> Âdrivers/gpio/gpio-altera.cÂÂÂÂÂÂÂ|ÂÂ3 +++
> Âdrivers/gpio/gpio-aspeed.cÂÂÂÂÂÂÂ|ÂÂ5 +++++
> Âdrivers/gpio/gpio-ath79.cÂÂÂÂÂÂÂÂ|ÂÂ2 ++
> Âdrivers/gpio/gpio-bcm-kona.cÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-clps711x.cÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-crystalcove.cÂÂ|ÂÂ2 ++
> Âdrivers/gpio/gpio-dln2.cÂÂÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-dwapb.cÂÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-etraxfs.cÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-f7188x.cÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-ftgpio010.cÂÂÂÂ|ÂÂ3 +++
> Âdrivers/gpio/gpio-ingenic.cÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-intel-mid.cÂÂÂÂ|ÂÂ2 ++
> Âdrivers/gpio/gpio-lp873x.cÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-lynxpoint.cÂÂÂÂ|ÂÂ2 ++
> Âdrivers/gpio/gpio-max732x.cÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-max77620.cÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-menz127.cÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-merrifield.cÂÂÂ|ÂÂ4 ++++
> Âdrivers/gpio/gpio-omap.cÂÂÂÂÂÂÂÂÂ|ÂÂ3 +++
> Âdrivers/gpio/gpio-pca953x.cÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-pci-idio-16.cÂÂ|ÂÂ2 ++
> Âdrivers/gpio/gpio-pisosr.cÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-pl061.cÂÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-rcar.cÂÂÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-stmpe.cÂÂÂÂÂÂÂÂ|ÂÂ2 ++
> Âdrivers/gpio/gpio-tc3589x.cÂÂÂÂÂÂ|ÂÂ3 +++
> Âdrivers/gpio/gpio-tegra.cÂÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-tps65218.cÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-vf610.cÂÂÂÂÂÂÂÂ|ÂÂ3 +++
> Âdrivers/gpio/gpio-vx855.cÂÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-wcove.cÂÂÂÂÂÂÂÂ|ÂÂ2 ++
> Âdrivers/gpio/gpio-wm831x.cÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-wm8994.cÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-ws16c48.cÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-xgene-sb.cÂÂÂÂÂ|ÂÂ2 ++
> Âdrivers/gpio/gpio-xlp.cÂÂÂÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-zx.cÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpio-zynq.cÂÂÂÂÂÂÂÂÂ|ÂÂ3 +++
> Âdrivers/gpio/gpiolib-acpi.cÂÂÂÂÂÂ|ÂÂ1 +
> Âdrivers/gpio/gpiolib.cÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ2 ++
> Âinclude/linux/gpio/driver.hÂÂÂÂÂÂ| 11 ++++++-----
> Â46 files changed, 80 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-104-dio-48e.c b/drivers/gpio/gpio-104-
> dio-48e.c
> index 598e209efa2d..bdc52be7902a 100644
> --- a/drivers/gpio/gpio-104-dio-48e.c
> +++ b/drivers/gpio/gpio-104-dio-48e.c
> @@ -22,6 +22,7 @@
> Â#include <linux/ioport.h>
> Â#include <linux/interrupt.h>
> Â#include <linux/irqdesc.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/isa.h>
> Â#include <linux/kernel.h>
> Â#include <linux/module.h>
> diff --git a/drivers/gpio/gpio-104-idi-48.c b/drivers/gpio/gpio-104-
> idi-48.c
> index 51f046e29ff7..7bbb0e8573d1 100644
> --- a/drivers/gpio/gpio-104-idi-48.c
> +++ b/drivers/gpio/gpio-104-idi-48.c
> @@ -22,6 +22,7 @@
> Â#include <linux/ioport.h>
> Â#include <linux/interrupt.h>
> Â#include <linux/irqdesc.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/isa.h>
> Â#include <linux/kernel.h>
> Â#include <linux/module.h>
> diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-
> idio-16.c
> index ec2ce34ff473..7e3fc0bf3398 100644
> --- a/drivers/gpio/gpio-104-idio-16.c
> +++ b/drivers/gpio/gpio-104-idio-16.c
> @@ -22,6 +22,7 @@
> Â#include <linux/ioport.h>
> Â#include <linux/interrupt.h>
> Â#include <linux/irqdesc.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/isa.h>
> Â#include <linux/kernel.h>
> Â#include <linux/module.h>
> diff --git a/drivers/gpio/gpio-altera-a10sr.c b/drivers/gpio/gpio-
> altera-a10sr.c
> index 16a8951b2bed..4cdca9332043 100644
> --- a/drivers/gpio/gpio-altera-a10sr.c
> +++ b/drivers/gpio/gpio-altera-a10sr.c
> @@ -21,6 +21,8 @@
> Â#include <linux/gpio/driver.h>
> Â#include <linux/mfd/altera-a10sr.h>
> Â#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> Â
> Â/**
> Â * struct altr_a10sr_gpio - Altera Max5 GPIO device private data
> structure
> diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c
> index 17485dc20384..40b26274acaf 100644
> --- a/drivers/gpio/gpio-altera.c
> +++ b/drivers/gpio/gpio-altera.c
> @@ -17,6 +17,9 @@
> Â */
> Â
> Â#include <linux/io.h>
> +#include <linux/irq.h>
> +#include <linux/irqchip/chained_irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/module.h>
> Â#include <linux/of_gpio.h>
> Â#include <linux/platform_device.h>
> diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
> index 4ca436e66bdb..a9d575e215da 100644
> --- a/drivers/gpio/gpio-aspeed.c
> +++ b/drivers/gpio/gpio-aspeed.c
> @@ -15,9 +15,14 @@
> Â#include <linux/hashtable.h>
> Â#include <linux/init.h>
> Â#include <linux/io.h>
> +#include <linux/irq.h>
> +#include <linux/irqchip/chained_irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/kernel.h>
> Â#include <linux/module.h>
> +#include <linux/of.h>
> Â#include <linux/pinctrl/consumer.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/spinlock.h>
> Â#include <linux/string.h>
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index f33d4a5fe671..1249ab0f8f4f 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -17,6 +17,8 @@
> Â#include <linux/interrupt.h>
> Â#include <linux/module.h>
> Â#include <linux/irq.h>
> +#include <linux/irqchip/chained_irq.h>
> +#include <linux/irqdomain.h>
> Â
> Â#define AR71XX_GPIO_REG_OE 0x00
> Â#define AR71XX_GPIO_REG_IN 0x04
> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-
> kona.c
> index dfcf56ee3c61..937d646d184b 100644
> --- a/drivers/gpio/gpio-bcm-kona.c
> +++ b/drivers/gpio/gpio-bcm-kona.c
> @@ -23,6 +23,7 @@
> Â#include <linux/init.h>
> Â#include <linux/irqdomain.h>
> Â#include <linux/irqchip/chained_irq.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â
> Â#define BCM_GPIO_PASSWD 0x00a5a501
> Â#define GPIO_PER_BANK 32
> diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-
> clps711x.c
> index 52fd63f02134..1f499b5e7f91 100644
> --- a/drivers/gpio/gpio-clps711x.c
> +++ b/drivers/gpio/gpio-clps711x.c
> @@ -12,6 +12,7 @@
> Â#include <linux/err.h>
> Â#include <linux/module.h>
> Â#include <linux/gpio/driver.h>
> +#include <linux/of.h>
> Â#include <linux/platform_device.h>
> Â
> Âstatic int clps711x_gpio_probe(struct platform_device *pdev)
> diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-
> crystalcove.c
> index e60156ec0c18..0f66ae796d4a 100644
> --- a/drivers/gpio/gpio-crystalcove.c
> +++ b/drivers/gpio/gpio-crystalcove.c
> @@ -16,6 +16,8 @@
> Â */
> Â
> Â#include <linux/interrupt.h>
> +#include <linux/irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/module.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/gpio.h>
> diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c
> index aecb847166f5..d524f3390196 100644
> --- a/drivers/gpio/gpio-dln2.c
> +++ b/drivers/gpio/gpio-dln2.c
> @@ -17,6 +17,7 @@
> Â#include <linux/irqchip/chained_irq.h>
> Â#include <linux/gpio.h>
> Â#include <linux/gpio/driver.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/mfd/dln2.h>
> Â
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index c07ada9c7af6..350454b9359e 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -23,6 +23,7 @@
> Â#include <linux/of_address.h>
> Â#include <linux/of_device.h>
> Â#include <linux/of_irq.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/property.h>
> Â#include <linux/spinlock.h>
> diff --git a/drivers/gpio/gpio-etraxfs.c b/drivers/gpio/gpio-etraxfs.c
> index 14c6aac26780..ef518aacbeac 100644
> --- a/drivers/gpio/gpio-etraxfs.c
> +++ b/drivers/gpio/gpio-etraxfs.c
> @@ -4,6 +4,7 @@
> Â#include <linux/of_gpio.h>
> Â#include <linux/io.h>
> Â#include <linux/interrupt.h>
> +#include <linux/irq.h>
> Â#include <linux/platform_device.h>
> Â
> Â#define ETRAX_FS_rw_pa_dout 0
> diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
> index 13350c9d7f5e..08604a76d543 100644
> --- a/drivers/gpio/gpio-f7188x.c
> +++ b/drivers/gpio/gpio-f7188x.c
> @@ -17,6 +17,7 @@
> Â#include <linux/io.h>
> Â#include <linux/gpio/driver.h>
> Â#include <linux/bitops.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â
> Â#define DRVNAME "gpio-f7188x"
> Â
> diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-
> ftgpio010.c
> index e9386f8b67f5..699a3709e357 100644
> --- a/drivers/gpio/gpio-ftgpio010.c
> +++ b/drivers/gpio/gpio-ftgpio010.c
> @@ -12,6 +12,9 @@
> Â#include <linux/gpio/driver.h>
> Â#include <linux/io.h>
> Â#include <linux/interrupt.h>
> +#include <linux/irq.h>
> +#include <linux/irqchip/chained_irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/of_gpio.h>
> Â#include <linux/bitops.h>
> diff --git a/drivers/gpio/gpio-ingenic.c b/drivers/gpio/gpio-ingenic.c
> index 254780730b95..7ec8de5ee926 100644
> --- a/drivers/gpio/gpio-ingenic.c
> +++ b/drivers/gpio/gpio-ingenic.c
> @@ -9,6 +9,7 @@
> Â#include <linux/gpio/driver.h>
> Â#include <linux/interrupt.h>
> Â#include <linux/io.h>
> +#include <linux/irqchip/chained_irq.h>
> Â#include <linux/module.h>
> Â#include <linux/of_address.h>
> Â#include <linux/of_device.h>
> diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-
> mid.c
> index b76ecee82c3f..af6b7d27ee41 100644
> --- a/drivers/gpio/gpio-intel-mid.c
> +++ b/drivers/gpio/gpio-intel-mid.c
> @@ -23,6 +23,8 @@
> Â#include <linux/init.h>
> Â#include <linux/interrupt.h>
> Â#include <linux/io.h>
> +#include <linux/irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/gpio/driver.h>
> Â#include <linux/kernel.h>
> Â#include <linux/module.h>
> diff --git a/drivers/gpio/gpio-lp873x.c b/drivers/gpio/gpio-lp873x.c
> index df0ad2cef0d2..1cd5e7e08ad9 100644
> --- a/drivers/gpio/gpio-lp873x.c
> +++ b/drivers/gpio/gpio-lp873x.c
> @@ -16,6 +16,7 @@
> Â
> Â#include <linux/gpio.h>
> Â#include <linux/module.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/regmap.h>
> Â
> diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-
> lynxpoint.c
> index fbd393b46ce0..9adbbac2ba5b 100644
> --- a/drivers/gpio/gpio-lynxpoint.c
> +++ b/drivers/gpio/gpio-lynxpoint.c
> @@ -25,6 +25,8 @@
> Â#include <linux/types.h>
> Â#include <linux/bitops.h>
> Â#include <linux/interrupt.h>
> +#include <linux/irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/gpio.h>
> Â#include <linux/slab.h>
> Â#include <linux/acpi.h>
> diff --git a/drivers/gpio/gpio-max732x.c b/drivers/gpio/gpio-max732x.c
> index 7f4d26ce5f23..c277278af532 100644
> --- a/drivers/gpio/gpio-max732x.c
> +++ b/drivers/gpio/gpio-max732x.c
> @@ -20,6 +20,7 @@
> Â#include <linux/gpio/driver.h>
> Â#include <linux/interrupt.h>
> Â#include <linux/i2c.h>
> +#include <linux/irq.h>
> Â#include <linux/platform_data/max732x.h>
> Â#include <linux/of.h>
> Â
> diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-
> max77620.c
> index 743459d9477d..35dd0f133028 100644
> --- a/drivers/gpio/gpio-max77620.c
> +++ b/drivers/gpio/gpio-max77620.c
> @@ -12,6 +12,7 @@
> Â#include <linux/interrupt.h>
> Â#include <linux/mfd/max77620.h>
> Â#include <linux/module.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/regmap.h>
> Â
> diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
> index e1037582e34d..f265a841f787 100644
> --- a/drivers/gpio/gpio-menz127.c
> +++ b/drivers/gpio/gpio-menz127.c
> @@ -15,6 +15,7 @@
> Â#include <linux/mcb.h>
> Â#include <linux/bitops.h>
> Â#include <linux/gpio/driver.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â
> Â#define MEN_Z127_CTRL 0x00
> Â#define MEN_Z127_PSR 0x04
> diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio-
> merrifield.c
> index ec8560298805..2d84fcbe060f 100644
> --- a/drivers/gpio/gpio-merrifield.c
> +++ b/drivers/gpio/gpio-merrifield.c
> @@ -14,8 +14,12 @@
> Â#include <linux/init.h>
> Â#include <linux/interrupt.h>
> Â#include <linux/io.h>
> +#include <linux/irq.h>
> +#include <linux/irqchip/chained_irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/module.h>
> Â#include <linux/pci.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/pinctrl/consumer.h>
> Â
> Â#define GCCR 0x000 /* controller configuration
> */
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index f8c550de6c72..7ef062e14777 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -19,6 +19,8 @@
> Â#include <linux/err.h>
> Â#include <linux/clk.h>
> Â#include <linux/io.h>
> +#include <linux/irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/device.h>
> Â#include <linux/pm_runtime.h>
> Â#include <linux/pm.h>
> @@ -26,6 +28,7 @@
> Â#include <linux/of_device.h>
> Â#include <linux/gpio.h>
> Â#include <linux/bitops.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_data/gpio-omap.h>
> Â
> Â#define OFF_MODE 1
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 4c9e21300a26..58a68ba8311f 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -17,6 +17,7 @@
> Â#include <linux/i2c.h>
> Â#include <linux/init.h>
> Â#include <linux/interrupt.h>
> +#include <linux/irq.h>
> Â#include <linux/module.h>
> Â#include <linux/of_platform.h>
> Â#include <linux/platform_data/pca953x.h>
> diff --git a/drivers/gpio/gpio-pci-idio-16.c b/drivers/gpio/gpio-pci-
> idio-16.c
> index 7de4f6a2cb49..313da56389f4 100644
> --- a/drivers/gpio/gpio-pci-idio-16.c
> +++ b/drivers/gpio/gpio-pci-idio-16.c
> @@ -16,7 +16,9 @@
> Â#include <linux/errno.h>
> Â#include <linux/gpio/driver.h>
> Â#include <linux/interrupt.h>
> +#include <linux/irq.h>
> Â#include <linux/irqdesc.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/kernel.h>
> Â#include <linux/module.h>
> Â#include <linux/pci.h>
> diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c
> index f5545049c187..4cca0c4dd85a 100644
> --- a/drivers/gpio/gpio-pisosr.c
> +++ b/drivers/gpio/gpio-pisosr.c
> @@ -17,6 +17,7 @@
> Â#include <linux/gpio/driver.h>
> Â#include <linux/module.h>
> Â#include <linux/mutex.h>
> +#include <linux/of.h>
> Â#include <linux/spi/spi.h>
> Â
> Â#define DEFAULT_NGPIO 8
> diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
> index 3d3d6b6645a7..8d502a83babc 100644
> --- a/drivers/gpio/gpio-pl061.c
> +++ b/drivers/gpio/gpio-pl061.c
> @@ -19,6 +19,7 @@
> Â#include <linux/interrupt.h>
> Â#include <linux/irq.h>
> Â#include <linux/irqchip/chained_irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/bitops.h>
> Â#include <linux/gpio.h>
> Â#include <linux/device.h>
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 4a1536a050bc..9b2b00974163 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -22,6 +22,7 @@
> Â#include <linux/io.h>
> Â#include <linux/ioport.h>
> Â#include <linux/irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/module.h>
> Â#include <linux/of.h>
> Â#include <linux/pinctrl/consumer.h>
> diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c
> index 16cbc5702865..0e6fae84c759 100644
> --- a/drivers/gpio/gpio-stmpe.c
> +++ b/drivers/gpio/gpio-stmpe.c
> @@ -10,6 +10,8 @@
> Â#include <linux/slab.h>
> Â#include <linux/gpio.h>
> Â#include <linux/interrupt.h>
> +#include <linux/irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/of.h>
> Â#include <linux/mfd/stmpe.h>
> Â#include <linux/seq_file.h>
> diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
> index 433b45ef332e..d0ec9902d9c1 100644
> --- a/drivers/gpio/gpio-tc3589x.c
> +++ b/drivers/gpio/gpio-tc3589x.c
> @@ -12,8 +12,11 @@
> Â#include <linux/gpio/driver.h>
> Â#include <linux/of.h>
> Â#include <linux/interrupt.h>
> +#include <linux/irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/mfd/tc3589x.h>
> Â#include <linux/bitops.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â
> Â/*
> Â * These registers are modified under the irq bus lock and cached to
> avoid
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index 88529d3c06c9..5e012377be1e 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -29,6 +29,7 @@
> Â#include <linux/irqdomain.h>
> Â#include <linux/irqchip/chained_irq.h>
> Â#include <linux/pinctrl/consumer.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/pm.h>
> Â
> Â#define GPIO_BANK(x) ((x) >> 5)
> diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-
> tps65218.c
> index a379bba57d31..97dca93b0529 100644
> --- a/drivers/gpio/gpio-tps65218.c
> +++ b/drivers/gpio/gpio-tps65218.c
> @@ -15,6 +15,7 @@
> Â#include <linux/module.h>
> Â#include <linux/errno.h>
> Â#include <linux/gpio/driver.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/regmap.h>
> Â#include <linux/mfd/tps65218.h>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 521fbe338589..844bf591268b 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -23,6 +23,9 @@
> Â#include <linux/io.h>
> Â#include <linux/ioport.h>
> Â#include <linux/irq.h>
> +#include <linux/irqchip/chained_irq.h>
> +#include <linux/pinctrl/consumer.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/of.h>
> Â#include <linux/of_device.h>
> diff --git a/drivers/gpio/gpio-vx855.c b/drivers/gpio/gpio-vx855.c
> index 98a6f1fcc561..96331a43c2c1 100644
> --- a/drivers/gpio/gpio-vx855.c
> +++ b/drivers/gpio/gpio-vx855.c
> @@ -28,6 +28,7 @@
> Â#include <linux/gpio.h>
> Â#include <linux/slab.h>
> Â#include <linux/device.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/pci.h>
> Â#include <linux/io.h>
> diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c
> index 37c103e50ebf..78161e22a859 100644
> --- a/drivers/gpio/gpio-wcove.c
> +++ b/drivers/gpio/gpio-wcove.c
> @@ -18,8 +18,10 @@
> Â#include <linux/bitops.h>
> Â#include <linux/module.h>
> Â#include <linux/interrupt.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/gpio/driver.h>
> Â#include <linux/mfd/intel_soc_pmic.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/regmap.h>
> Â#include <linux/seq_file.h>
> diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c
> index 938bbe3f831c..b9f2f95a1309 100644
> --- a/drivers/gpio/gpio-wm831x.c
> +++ b/drivers/gpio/gpio-wm831x.c
> @@ -17,6 +17,7 @@
> Â#include <linux/module.h>
> Â#include <linux/gpio.h>
> Â#include <linux/mfd/core.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/seq_file.h>
> Â
> diff --git a/drivers/gpio/gpio-wm8994.c b/drivers/gpio/gpio-wm8994.c
> index 1e35756ac55b..f2708fa3eefb 100644
> --- a/drivers/gpio/gpio-wm8994.c
> +++ b/drivers/gpio/gpio-wm8994.c
> @@ -17,6 +17,7 @@
> Â#include <linux/module.h>
> Â#include <linux/gpio.h>
> Â#include <linux/mfd/core.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/seq_file.h>
> Â#include <linux/regmap.h>
> diff --git a/drivers/gpio/gpio-ws16c48.c b/drivers/gpio/gpio-ws16c48.c
> index 5037974ac063..9eb42b983c75 100644
> --- a/drivers/gpio/gpio-ws16c48.c
> +++ b/drivers/gpio/gpio-ws16c48.c
> @@ -19,6 +19,7 @@
> Â#include <linux/ioport.h>
> Â#include <linux/interrupt.h>
> Â#include <linux/irqdesc.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/isa.h>
> Â#include <linux/kernel.h>
> Â#include <linux/module.h>
> diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-
> sb.c
> index 033258634b8c..f0929da6c385 100644
> --- a/drivers/gpio/gpio-xgene-sb.c
> +++ b/drivers/gpio/gpio-xgene-sb.c
> @@ -22,6 +22,8 @@
> Â
> Â#include <linux/module.h>
> Â#include <linux/io.h>
> +#include <linux/irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/of_gpio.h>
> Â#include <linux/gpio/driver.h>
> diff --git a/drivers/gpio/gpio-xlp.c b/drivers/gpio/gpio-xlp.c
> index d857e1d8e731..646856127aa6 100644
> --- a/drivers/gpio/gpio-xlp.c
> +++ b/drivers/gpio/gpio-xlp.c
> @@ -17,6 +17,7 @@
> Â#include <linux/of_device.h>
> Â#include <linux/module.h>
> Â#include <linux/irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/interrupt.h>
> Â#include <linux/irqchip/chained_irq.h>
> Â#include <linux/acpi.h>
> diff --git a/drivers/gpio/gpio-zx.c b/drivers/gpio/gpio-zx.c
> index be3a87da8438..4259ae6ff44c 100644
> --- a/drivers/gpio/gpio-zx.c
> +++ b/drivers/gpio/gpio-zx.c
> @@ -14,6 +14,7 @@
> Â#include <linux/errno.h>
> Â#include <linux/gpio/driver.h>
> Â#include <linux/irqchip/chained_irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/init.h>
> Â#include <linux/of.h>
> Â#include <linux/pinctrl/consumer.h>
> diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
> index df0851464006..e0a83e32caef 100644
> --- a/drivers/gpio/gpio-zynq.c
> +++ b/drivers/gpio/gpio-zynq.c
> @@ -15,6 +15,9 @@
> Â#include <linux/init.h>
> Â#include <linux/interrupt.h>
> Â#include <linux/io.h>
> +#include <linux/irq.h>
> +#include <linux/irqchip/chained_irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/module.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/pm_runtime.h>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index c9b42dd12dfa..2695a8cc3b71 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -18,6 +18,7 @@
> Â#include <linux/export.h>
> Â#include <linux/acpi.h>
> Â#include <linux/interrupt.h>
> +#include <linux/irq.h>
> Â#include <linux/mutex.h>
> Â#include <linux/pinctrl/pinctrl.h>
> Â
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 9568708a550b..b81269c00381 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -3,6 +3,7 @@
> Â#include <linux/module.h>
> Â#include <linux/interrupt.h>
> Â#include <linux/irq.h>
> +#include <linux/irqdomain.h>
> Â#include <linux/spinlock.h>
> Â#include <linux/list.h>
> Â#include <linux/device.h>
> @@ -17,6 +18,7 @@
> Â#include <linux/gpio/driver.h>
> Â#include <linux/gpio/machine.h>
> Â#include <linux/pinctrl/consumer.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> Â#include <linux/cdev.h>
> Â#include <linux/fs.h>
> Â#include <linux/uaccess.h>
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index af20369ec8e7..07b595e24695 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -1,21 +1,22 @@
> Â#ifndef __LINUX_GPIO_DRIVER_H
> Â#define __LINUX_GPIO_DRIVER_H
> Â
> -#include <linux/device.h>
> Â#include <linux/types.h>
> -#include <linux/irq.h>
> -#include <linux/irqchip/chained_irq.h>
> -#include <linux/irqdomain.h>
> +#include <linux/irqhandler.h>
> Â#include <linux/lockdep.h>
> Â#include <linux/pinctrl/pinctrl.h>
> -#include <linux/pinctrl/pinconf-generic.h>
> +#include <linux/spinlock_types.h>
> Â
> Âstruct gpio_desc;
> Âstruct of_phandle_args;
> +struct device;
> Âstruct device_node;
> +struct irq_chip;
> +struct irq_domain;
> Âstruct seq_file;
> Âstruct gpio_device;
> Âstruct module;
> +struct pinctrl_dev;
> Â
> Â#ifdef CONFIG_GPIOLIB
> Â

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy

Next message: Lorenzo Pieralisi: "Re: [PATCH v3 2/2] acpi/iort: numa: Add numa node mapping for smmuv3 devices"
Previous message: Geert Uytterhoeven: "[PATCH] genirq: Force inlining of __irq_startup_managed to prevent build failure"
In reply to: Charles Keepax: "Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h"
Next in thread: Masahiro Yamada: "Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]