Re: [PATCH] bus: arm-ccn: constify attribute_group structures.
From: Pawel Moll
Date: Tue Jul 04 2017 - 07:27:25 EST
On Mon, 2017-07-03 at 13:01 +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> ÂÂÂtext ÂÂÂdata ÂÂÂÂbss ÂÂÂÂdec ÂÂÂÂhex filename
> ÂÂÂ9074 ÂÂÂ5592 ÂÂÂÂ416 ÂÂ15082 ÂÂÂ3aea drivers/bus/arm-ccn.o
>
> File size After adding 'const':
> ÂÂÂtext ÂÂÂdata ÂÂÂÂbss ÂÂÂÂdec ÂÂÂÂhex filename
> ÂÂÂ9327 ÂÂÂ5336 ÂÂÂÂ416 ÂÂ15079 ÂÂÂ3ae7 drivers/bus/arm-ccn.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
Looks fine to me. I'll queue it for the next time I push out CCN driver
fixes (no dates promised, though...)
Thanks!
PaweÅ