RE: Re: [PATCH] PM / devfreq: constify attribute_group structures.

[MyungJoo Ham]

> On 2017ë 07ì 03ì 19:10, Arvind Yadav wrote:
> > attribute_groups are not supposed to change at runtime. All functions
> > working with attribute_groups provided by <linux/sysfs.h> work with const
> > attribute_group. So mark the non-const structs as const.
> > 
> > File size before:
> >    text	   data	    bss	    dec	    hex	filename
> >     621	    176	      0	    797	    31d	drivers/devfreq/governor_userspace.o
> > 
> > File size After adding 'const':
> >    text	   data	    bss	    dec	    hex	filename
> >    670	    144	      0	    814	    32e	drivers/devfreq/governor_userspace.o
> > 
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> > ---
> >  drivers/devfreq/governor_userspace.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
[]
> 
> Looks good to me.
> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>

Thank you. Applying to for-rc branch.


Cheers,
MyungJoo