Re: [PATCH v9 0/3] Tango PCIe controller support
From: Bjorn Helgaas
Date: Wed Jul 05 2017 - 23:39:59 EST
On Wed, Jul 05, 2017 at 11:59:33PM +0200, Mason wrote:
> On 05/07/2017 23:34, Bjorn Helgaas wrote:
> > On Wed, Jul 05, 2017 at 10:39:19PM +0200, Mason wrote:
> >> On 05/07/2017 20:03, Bjorn Helgaas wrote:
> > If you confirm that
> > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-tango&id=d752a8b29345
> > works for you, I'll include it in my v4.13 pull request.
> There were a few nits I wanted to address:
> - Since we added suppress_bind_attrs = true, probe()
> can only be called at init, so I wanted to mark __init
> all the probe functions, to save space.
> - I left the definition of MSI_MAX in the wrong patch
> - You put a pointer to the pdev in the struct tango_pcie.
> I think this is redundant, since the pdev already has a
> pointer to the struct, as drvdata.
> So I wanted to change tango_msi_probe() to take a pdev
> as argument (to make it more like an actual probe function)
> and derive pcie from pdev, instead of the other way around.
I don't think tango_msi_probe() is really a "probe" function. It's
all part of the tango driver, and it's not claiming a separate piece
of hardware. So I would keep the name and structure similar to these:
BTW, those functions use irq_domain_add_linear(), while you are one of
the very few callers of irq_domain_create_linear(). Why the difference?
If your code does basically the same thing, it's very helpful to me if
it *looks* basically the same.
> Can I send you a patch series with these changes on Friday?
I was planning to ask Linus to pull my branch tomorrow or Friday
because I'm going on vacation next week and I don't want to leave
right after he pulls it. So the sooner the better.