Re: [PATCH v2 2/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

From: Viresh Kumar
Date: Thu Jul 06 2017 - 01:47:28 EST

On 05-07-17, 14:04, Patrick Bellasi wrote:
> On 05-Jul 10:20, Viresh Kumar wrote:
> > And also why is it important to write 0 to sg_cpu->flags ? What wouldn't work if
> > we set sg_cpu->flags to SCHED_CPUFREQ_IDLE in this case ? i.e. Just the below
> > statement should be good for us.
> Let say flags have the RT/DL flag set when the RT task sleep, is there
> any specific reason to keep this flag up while the CPU is IDLE?
> IOW, why should we care about an information related to an even which
> is now over?

Maybe I wasn't able to communicate what I wanted to say, but I am not asking you
to keep RT/DL flags as is, but rather set the flags variable to
SCHED_CPUFREQ_IDLE (1 << 3). My concerns were about adding an additional
conditional statement here, while we can live without one.

> The proposal of this patch is just meant to make sure that the flags,
> being a state variable, always describe the current status of the
> sugov "state machine".
> If a CPU is IDLE there are not sensible events going on and thus flags
> should better be reset.


> > This looks correct.
> >
> > Can we completely avoid the utilization contribution of the CPUs which have gone
> > idle? Right now we avoid them with help of (delta_ns > TICK_NSEC). Can we
> > instead check this SCHED_CPUFREQ_IDLE flag ?
> I would say that the blocked utilization of an IDLE CPU is still worth
> to be considered, at least for a limited amount of time, for few main
> reasons:
> 1. it represents CPU bandwidth that is likely to be required by a task
> which can wakeup in a short while. Consider for example an 80% task
> activated every 16ms: even if it's not running right now it's
> likely to wakeup in the next ~3ms to run for the following ~13ms.
> Thus, we should probably better consider that CPU utilization.
> 2. we already have policies to gratefully reduce the current OPP if
> its utilization decrease. This means that we are interested in a
> sort of policy which favors higher OPPs to avoid impacting
> performance of tasks which suddenly wakeup.
> 3. A CPU entering IDLE is not a great source of new information
> for OPP selection, I would not strictly bind an OPP change to this
> event. That's also why this patch propose to clear the flags
> without actually triggering an OPP change.
> Moreover, maybe the issue you are trying to solve it's more related to
> having a stale utilization for an IDLE CPUs?

I wasn't trying to solve any issue here, but just discussing about what should
we do here. Yeah it seems fair to keep the utilization of the idle CPU for
another TICK, after which we are ignoring it anyway.