Re: [PATCH v2 05/10] arm: wire frequency-invariant accounting support up to the task scheduler

From: Viresh Kumar
Date: Thu Jul 06 2017 - 06:47:07 EST


On 06-07-17, 10:49, Dietmar Eggemann wrote:
> Commit dfbca41f3479 ("sched: Optimize freq invariant accounting")
> changed the wiring which now has to be done by associating
> arch_scale_freq_capacity with the actual implementation provided
> by the architecture.
>
> Define arch_scale_freq_capacity to use the arch_topology "driver"
> function topology_get_freq_scale() for the task scheduler's
> frequency-invariant accounting instead of the default
> arch_scale_freq_capacity() in kernel/sched/sched.h.
>
> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> Cc: Juri Lelli <juri.lelli@xxxxxxx>
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
> Acked-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> Tested-by: Juri Lelli <juri.lelli@xxxxxxx>
> Reviewed-by: Juri Lelli <juri.lelli@xxxxxxx>
> ---
> arch/arm/include/asm/topology.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/include/asm/topology.h b/arch/arm/include/asm/topology.h
> index ca05d1b90411..57aebfa03e24 100644
> --- a/arch/arm/include/asm/topology.h
> +++ b/arch/arm/include/asm/topology.h
> @@ -29,6 +29,9 @@ const struct cpumask *cpu_coregroup_mask(int cpu);
> /* Subscribe for input data for frequency-invariant load-tracking */
> #define arch_set_freq_scale topology_set_freq_scale
>
> +/* Replace task scheduler's default frequency-invariant accounting */
> +#define arch_scale_freq_capacity topology_get_freq_scale
> +
> #else
>
> static inline void init_cpu_topology(void) { }

Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh