Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

From: Stafford Horne
Date: Thu Jul 06 2017 - 09:07:06 EST


On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote:
> On Tue, 4 Jul 2017 15:38:55 +0900
> Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
> > + local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > + else
> > + local testlog=`/proc/self/fd/1`
>
> cute trick.

Shouldn't this be:

local testlog=/proc/self/fd/1

without the backticks and subshell? We just want to write to the stdout
file not execute it.

Or am missing something.

-Stafford