Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328

From: Rob Herring
Date: Thu Jul 06 2017 - 13:18:11 EST


On Thu, Jun 29, 2017 at 08:27:50PM +0800, David Wu wrote:
> The rk3328 soc supports atomic update, we could lock the configuration
> of period and duty at first, after unlock is configured, the period and
> duty are effective at the same time.
>
> If the polarity, period and duty need to be configured together,
> the way for atomic update is "configure lock and old polarity" ->
> "configure period and duty" -> "configure unlock and new polarity".
>
> Signed-off-by: David Wu <david.wu@xxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/pwm/pwm-rockchip.txt | 1 +

The subject is a bit misleading as you are adding support for a new
version of the IP. Otherwise,

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> drivers/pwm/pwm-rockchip.c | 50 +++++++++++++++++++---
> 2 files changed, 46 insertions(+), 5 deletions(-)