Re: [PATCH v2 1/9] net/netfilter/nf_conntrack_core: Fix net_conntrack_lock()

From: Manfred Spraul
Date: Thu Jul 06 2017 - 14:46:11 EST


This is a multi-part message in MIME format. Hi Paul,

On 07/06/2017 01:31 AM, Paul E. McKenney wrote:
From: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>

As we want to remove spin_unlock_wait() and replace it with explicit
spin_lock()/spin_unlock() calls, we can use this to simplify the
locking.

In addition:
- Reading nf_conntrack_locks_all needs ACQUIRE memory ordering.
- The new code avoids the backwards loop.

Only slightly tested, I did not manage to trigger calls to
nf_conntrack_all_lock().

If you want:
Attached would be V2, with adapted comments.

--
Manfred