Re: [PATCH v6 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

From: Jose Abreu
Date: Fri Jul 07 2017 - 05:34:21 EST


On 06-07-2017 21:52, kbuild test robot wrote:
> drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_registered':
>>> drivers/media//platform/dwc/dw-hdmi-rx.c:1452:9: error: implicit declaration of function 'v4l2_async_subnotifier_register' [-Werror=implicit-function-declaration]
> return v4l2_async_subnotifier_register(&dw_dev->sd,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_unregistered':
>>> drivers/media//platform/dwc/dw-hdmi-rx.c:1462:2: error: implicit declaration of function 'v4l2_async_subnotifier_unregister' [-Werror=implicit-function-declaration]
> v4l2_async_subnotifier_unregister(&dw_dev->v4l2_notifier);

This one is expected. Required patch was not merged yet.

> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_parse_dt':
> drivers/media//platform/dwc/dw-hdmi-rx.c:1555:22: warning: unused variable 'notifier' [-Wunused-variable]
> struct device_node *notifier, *phy_node, *np = dw_dev->of_node;
> ^~~~~~~~
> drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_rx_probe':
> drivers/media//platform/dwc/dw-hdmi-rx.c:1765:1: warning: label 'err_phy' defined but not used [-Wunused-label]
> err_phy:
> ^~~~~~~
> cc1: some warnings being treated as errors
>
>

These two is due to cec not being enabled. I hate to wrap this
around a #ifdef but is either this or extract cec to a separate
file, which I don't think is the best solution because the cec
code is quite small.

Best regards,
Jose Miguel Abreu