Re: [PATCH] platform/x86: silead_dmi: Add touchscreen info for I.T.Works TW891 2-in-1

[Hans de Goede]

Hi,

On 07-07-17 00:39, Darren Hart wrote:
> On Sat, Jul 01, 2017 at 12:15:22PM +0200, Hans de Goede wrote:
> > Add touchscreen info for I.T.Works TW891 2-in-1.
>
> ...
>
> > +		/* I.T.Works TW891 */
> > +		.driver_data = (void *)&itworks_tw891_data,
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
>
> *groan* you're trolling me now right? ;-)

Nope, sorry, this seemed better then matching on a single
string. FWIW I did an internet search for TW891 and there are
no other devices named TW891.

> > +			DMI_MATCH(DMI_PRODUCT_NAME, "TW891"),
>
> I presume there are no other identifying strings?

Correct if there was something better I would have used it.

> Pushed to testing.

Thank you.

Regards,

Hans