Re: [PATCH] printk: Move printk_delay to separate file
From: Sergey Senozhatsky
Date: Sat Jul 08 2017 - 01:28:04 EST
On (07/07/17 11:08), Joe Perches wrote:
> printk.c is a huge file with too many local functions for a
> human to read and easily parse.
> Start to separate out bits into smaller files.
> o Rename suppress_message_printing to printk_suppress_message
> o Add function definitions to printk.h
I don't mind, in general, but I'm a bit hesitant. we want to have
automatic printk throttling (printk delay basically) and we need
some of those printk-internal *_seq numbers to see how far consoles
are behind the logbuf. so either we need to 'un-static' those *_seq
and extern them in delay.c or simply keep printk-delay machinery in
printk.c and add the new function.
// p.s. I'll take a look at the patch a bit later. I'm on a sick leave now.