Re: [PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree()

From: Bernd Petrovitsch
Date: Sat Jul 08 2017 - 04:59:14 EST


On Fri, 2017-07-07 at 20:41 -0400, Amitoj Kaur Chawla wrote:
[...]
> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
> @@ -117,11 +117,7 @@ void *atomisp_kernel_zalloc(size_t bytes, bool
> zero_mem)
> Â */
> Âvoid atomisp_kernel_free(void *ptr)
> Â{
> - /* Verify if buffer was allocated by vmalloc() or kmalloc()
> */
> - if (is_vmalloc_addr(ptr))
> - vfree(ptr);
> - else
> - kfree(ptr);
> + kvfree(ptr);
> Â}
> Â
> Â/*

Why not get rid of the trivial wrapper function completely?

MfG,
Bernd
--
Bernd Petrovitsch Email : bernd@xxxxxxxxxxxxxxxxxxx
LUGA : http://www.luga.at