Re: commit 67d7ddded32 (waitid(2): leave copyout of siginfo to syscall itself) breaks glibc posix/tst-waitid

From: Markus Trippelsdorf
Date: Sat Jul 08 2017 - 09:53:34 EST


On 2017.07.08 at 14:12 +0100, Al Viro wrote:
> On Sat, Jul 08, 2017 at 11:56:44AM +0200, Markus Trippelsdorf wrote:
> > Since:
> > commit 67d7ddded322db99f451a7959d56ed6c70a6c4aa
> > Author: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > Date: Sun May 14 20:53:13 2017 -0400
> >
> > waitid(2): leave copyout of siginfo to syscall itself
> >
> > the glibc posix/tst-waitid.c testcase fails:
> >
> > markus@x4 glibc-build % ./posix/tst-waitid
> > waitid WNOHANG on stopped status 0
>
> I think I see what's going on... We lose the distinction between "got
> a PID" and "nothing, but that's not an error" a bit too early waitid()
> case. Could you see if there are any problems left with the following
> applied?

No, everything looks nice now. Thanks.

--
Markus