Re: [patch 2/3] staging: speakup: use tty_kopen instead of tty_open_by_driver

[Greg Kroah-Hartman]

On Sun, Jul 09, 2017 at 12:41:55PM +0100, Okash Khawaja wrote:
> This patch replaces call to tty_open_by_driver with a tty_kopen.
> 
> Signed-off-by: Okash Khawaja <okash.khawaja@xxxxxxxxx>
> 
> ---
>  drivers/staging/speakup/spk_ttyio.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/staging/speakup/spk_ttyio.c
> +++ b/drivers/staging/speakup/spk_ttyio.c
> @@ -164,7 +164,7 @@ static int spk_ttyio_initialise_ldisc(st
>  	if (ret)
>  		return ret;
>  
> -	tty = tty_open_by_driver(dev, NULL, NULL);
> +	tty = tty_kopen(dev);
>  	if (IS_ERR(tty))

Hm, the "no tty layer" return value for this will be NULL.  I doubt
that's really a big deal, but perhaps just have that return
PTR_ERR(-ENODEV) or something?

thanks,

greg k-h