Re: [PATCH v2 5/5] Documentation/devicetree/bindings: Add FSI device documentation

[Rob Herring]

On Wed, Jul 05, 2017 at 04:36:57PM -0500, Eddie James wrote:
> From: "Edward A. James" <eajames@xxxxxxxxxx>

"dt-bindings: fsi: ..." for the subject.

> 
> Document the bindings for the SBE and OCC devices. SBE devices are
> located on a CFAM on an FSI bus, and OCC devices are accessed through
> the SBEFIFO.
> 
> Signed-off-by: Edward A. James <eajames@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt | 15 +++++++++++++++
>  .../devicetree/bindings/fsi/ibm,p9-sbefifo.txt       | 20 ++++++++++++++++++++
>  2 files changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
>  create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
> 
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> new file mode 100644
> index 0000000..766b706
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> @@ -0,0 +1,15 @@
> +Device-tree bindings for FSI-based On-Chip Controller driver
> +------------------------------------------------------------

Bindings are for h/w, not drivers.

> +
> +Required properties:
> + - compatible = "ibm,p9-occ";
> +
> +Optional properties:
> + - reg = <processor index>;	: Index for the processor this OCC is on.
> +
> +Examples:
> +
> +    occ@1 {
> +        compatible = "ibm,p9-occ";
> +        reg = <1>;
> +    };
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
> new file mode 100644
> index 0000000..d16ab9d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
> @@ -0,0 +1,20 @@
> +Device-tree bindings for FSI-based SBEFIFO driver
> +-------------------------------------------------

Bindings are for h/w, not drivers.

> +
> +Required properties:
> + - reg = < address size >		: FSI CFAM address for the SBE engine
> +					  and address space size.
> +
> +Optional properties:
> + - <child nodes>			: Devices that are accessible through
> +					  the SBEFIFO.
> +
> +Examples:
> +
> +    sbefifo@2400 {

This should have a compatible.

> +        reg = < 0x2400 0x400 >;
> +
> +        occ@1 {
> +            ...
> +        };
> +    };
> -- 
> 1.8.3.1
>