Re: [PATCH 3/3] dt-bindings: clock: amlogic,gxbb-aoclkc: Update bindings

From: Rob Herring
Date: Sun Jul 09 2017 - 23:50:38 EST

On Thu, Jul 06, 2017 at 12:24:23PM +0200, Neil Armstrong wrote:
> On the first revision of the bindings, only the gates + resets were known
> in the AO Clock HW, but more registers used to configures AO clock are known
> to be spread among the AO register space.
> This patch adds these registers to the Ao Clock bindings with direct access
> and shared extcon access.
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> ---
> .../devicetree/bindings/clock/amlogic,gxbb-aoclkc.txt | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)

This looks like the binding might be too specific with a reg list of
single registers, and you should define a system controller node
instead. Depends on what else is in the "A0" block.

Acked-by: Rob Herring <robh@xxxxxxxxxx>