Re: [PATCH 1/4] arm64: tegra: Add BPMP thermal sensor to Tegra186

[Mikko Perttunen]

On 01.07.2017 02:56, Eduardo Valentin wrote:
> On Fri, Jun 16, 2017 at 02:28:22PM +0300, Mikko Perttunen wrote:
> > This adds the thermal sensor device provided by the BPMP, and the
> > relevant thermal sensors to the Tegra186 device tree.
> >
> > Signed-off-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/nvidia/tegra186.dtsi | 48 ++++++++++++++++++++++++++++++++
> >  1 file changed, 48 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> > index 5e62e68ac053..5c19ea74da24 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> > @@ -4,6 +4,7 @@
> >  #include <dt-bindings/mailbox/tegra186-hsp.h>
> >  #include <dt-bindings/power/tegra186-powergate.h>
> >  #include <dt-bindings/reset/tegra186-reset.h>
> > +#include <dt-bindings/thermal/tegra186-bpmp-thermal.h>
> >
> >  / {
> >  	compatible = "nvidia,tegra186";
> > @@ -444,6 +445,53 @@
> >  			#size-cells = <0>;
> >  			status = "disabled";
> >  		};
> > +
> > +		bpmp_thermal: thermal {
> > +			compatible = "nvidia,tegra186-bpmp-thermal";
> > +			#thermal-sensor-cells = <1>;
> > +		};
> > +	};
> > +
> > +	thermal-zones {
> > +		a57 {
> > +			polling-delay = <0>;
> > +			polling-delay-passive = <1000>;
> > +
> > +			thermal-sensors =
> > +				<&bpmp_thermal TEGRA186_BPMP_THERMAL_ZONE_CPU>;
> > +		};
> > +
> > +		denver {
> > +			polling-delay = <0>;
> > +			polling-delay-passive = <1000>;
> > +
> > +			thermal-sensors =
> > +				<&bpmp_thermal TEGRA186_BPMP_THERMAL_ZONE_AUX>;
> > +		};
> > +
> > +		gpu {
> > +			polling-delay = <0>;
> > +			polling-delay-passive = <1000>;
> > +
> > +			thermal-sensors =
> > +				<&bpmp_thermal TEGRA186_BPMP_THERMAL_ZONE_GPU>;
> > +		};
> > +
> > +		pll {
> > +			polling-delay = <0>;
> > +			polling-delay-passive = <1000>;
> > +
> > +			thermal-sensors =
> > +				<&bpmp_thermal TEGRA186_BPMP_THERMAL_ZONE_PLLX>;
> > +		};
> > +
> > +		always_on {
> > +			polling-delay = <0>;
> > +			polling-delay-passive = <1000>;
> > +
> > +			thermal-sensors =
> > +				<&bpmp_thermal TEGRA186_BPMP_THERMAL_ZONE_AO>;
> > +		};
>
> All the above zones are lacking mandatory fields. Please refer to the
> thermal binding documentation.

Will fix.

> >  	};
> >
> >  	timer {
> > --
> > 2.13.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html