Re: [PATCH] microblaze/PCI: Remove pcibios_setup_bus_{self/devices} dead code

[Lorenzo Pieralisi]

Hi Michal,

On Tue, Jun 20, 2017 at 04:32:41PM +0200, Michal Simek wrote:
> Hi,
> 
> On 20.6.2017 15:08, Lorenzo Pieralisi wrote:
> > commit 01cf9d524ff0 ("microblaze/PCI: Support generic Xilinx AXI PCIe Host
> > Bridge IP driver") removed pcibios calls to:
> > 
> > pcibios_setup_bus_self()
> > pcibios_setup_bus_devices()
> > 
> > Given that pcibios_fixup_bus() was the only caller of those functions
> > they have now become dead code (along with the functions they were
> > calling in turn) so they can be removed.
> > 
> > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> > Cc: Bharat Kumar Gogada <bharatku@xxxxxxxxxx>
> > Cc: Ravi Kiran Gummaluri <rgummal@xxxxxxxxxx>
> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > Cc: Michal Simek <michal.simek@xxxxxxxxxx>
> > ---
> > Bjorn, Michal,
> > 
> > spotted this while reading microblaze code that parses legacy IRQs,
> > I am not familiar with microblaze code but as things stand those
> > pcibios calls are just unused IIUC.
> 
> TBH this code should never go to the tree. I even don't have any pci
> platform I can use for testing.
> I am happy to add this patch via microblaze tree.
> If you want to take it via pci tree here is my
> Acked-by: Michal Simek <michal.simek@xxxxxxxxxx>

Either way is fine by me as long as we merge it, I do not see it
in the mainline please let me know how you prefer handling it.

Thanks,
Lorenzo