Re: [PATCH v3 3/4] dt-bindings: Document MIPS Broadcom STB power management nodes

From: Rob Herring
Date: Mon Jul 10 2017 - 10:14:00 EST


On Thu, Jul 06, 2017 at 03:22:24PM -0700, Florian Fainelli wrote:
> Document the different nodes required for supporting S2/S3/S5 suspend
> states on MIPS-based Broadcom STB SoCs.
>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> ---
> .../devicetree/bindings/mips/brcm/soc.txt | 153 +++++++++++++++++++++
> 1 file changed, 153 insertions(+)

A couple of nits on the node names, otherwise:

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> +Example:
> +
> + memory-controller: memc@0 {

memory-controller@0

> + compatible = "brcm,brcmstb-memc", "simple-bus";
> + ranges = <0x0 0x0 0xa000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + memc-arb@1000 {
> + ...
> + };
> +
> + memc-ddr@2000 {
> + ...
> + };
> +
> + ddr-phy@6000 {
> + ...
> + };
> + };


> +Example:
> +
> + timers: timers@4067c0 {

timer@...

> + compatible = "brcm,bcm7425-timers", "brcm,brcmstb-timers";
> + reg = <0x4067c0 0x40>;
> + interrupts = <&periph_intc 19>;
> + };
> --
> 2.9.3
>