Re: [PATCH] binfmt_flat: fix format string for u32

From: Joe Perches
Date: Mon Jul 10 2017 - 11:49:16 EST


On Mon, 2017-07-10 at 13:08 +0200, Arnd Bergmann wrote:
> The types have changed from 'unsigned long' to 'u32', so now the
> format string is wrong, and produces a harmless warning on arm32:
[]
> This changes it to '%d' instead, matching the 'u32' type.
[]
> diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
[]
> @@ -574,7 +574,7 @@ static int load_flat_file(struct linux_binprm *bprm,
> MAX_SHARED_LIBS * sizeof(unsigned long),
> FLAT_DATA_ALIGN);
>
> - pr_debug("Allocated data+bss+stack (%ld bytes): %lx\n",
> + pr_debug("Allocated data+bss+stack (%d bytes): %lx\n",
> data_len + bss_len + stack_len, datapos);

Ideally, %u not %d as data_len, bss_len and stack_len are all u32