Re: [PATCH] iio: multiplexer: add NULL check on devm_kzalloc() and devm_kmemdup() return values

[Gustavo A. R. Silva]

Hi Jonathan,

Quoting Jonathan Cameron <jic23@xxxxxxxxxx>:

> On Fri, 7 Jul 2017 11:26:35 +0200
> Peter Rosin <peda@xxxxxxxxxx> wrote:
>
> > On 2017-07-07 06:57, Peter Rosin wrote:
> > > On 2017-07-07 06:53, Gustavo A. R. Silva wrote:
> > >> Check return values from call to devm_kzalloc() and devm_kmemup()
> > >
> > > If someone cares enough: s/devm_kmemup/evm_kmemdup/
> >
> > Strange, there seems to be some inherent shortage of 'd' characters...
> >
> > Cheers,
> > pea :-)
> >
> > >
> > >> in order to prevent a NULL pointer dereference.
> > >>
> > >> This issue was detected using Coccinelle and the following  
> > semantic patch:
> > >>
> > >> @@
> > >> expression x;
> > >> identifier fld;
> > >> @@
> > >>
> > >> * x = devm_kzalloc(...);
> > >>    ... when != x == NULL
> > >>    x->fld
> > >>
> > >> Cc: Peter Rosin <peda@xxxxxxxxxx>
> > >> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> > >
> > > Either way,
> > >
> > > Reviewed-by: Peter Rosin <peda@xxxxxxxxxx>
> > >
> > > Thanks!
> > >
> The relevant patch adding the file in questions hasn't yet worked it's
> way back to the iio tree so I can't apply this until it does.
>
> That is likely to be a few weeks away yet.  Please give me a poke if
> I seem to have forgotten it!

OK, I will do that. :)

Thanks!
--
Gustavo A. R. Silva