Re: [HMM 12/15] mm/migrate: new memory migration helper for use with device memory v4

From: Evgeny Baskakov
Date: Mon Jul 10 2017 - 20:17:29 EST

On 7/10/17 4:43 PM, Jerome Glisse wrote:

On Mon, Jul 10, 2017 at 03:59:37PM -0700, Evgeny Baskakov wrote:
Horrible stupid bug in the code, most likely from cut and paste. Attached
patch should fix it. I don't know how long it took for you to trigger it.

Thanks, this indeed fixes the problem! Yes, it took a nightly run before it triggered.

One a side note, should this "return NULL" be replaced with "return ERR_PTR(-ENOMEM)"?

struct hmm_device *hmm_device_new(void *drvdata)
if (hmm_device->minor >= HMM_DEVICE_MAX) {
-> return NULL;


Evgeny Baskakov