Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value

From: Mark yao
Date: Mon Jul 10 2017 - 20:45:21 EST

On 2017å07æ11æ 03:04, Sean Paul wrote:
On Fri, Jul 07, 2017 at 08:56:28AM +0800, Mark yao wrote:
On 2017å07æ07æ 05:58, Gustavo A. R. Silva wrote:
The right variable to check here is port, not dp.

This issue was detected using Coccinelle and the following semantic patch:

expression x;
identifier fld;

* x = devm_kzalloc(...);
... when != x == NULL

Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
Thanks for the fix,

Acked-by: Mark Yao <mark.yao@xxxxxxxxxxxxxx>
Hi Mark,
I've applied this patch, but in the future, please apply changes directly
instead of just acking.

If you're unable to apply it for some reason (vacation, etc), please reach out to
one of the -misc maintainers via email or irc so we don't inadvertently lose track
of it on the list.

Hi Sean

Got it, I will do it right next time.
Thanks to inform me this,

drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index 14fa1f8..9b0b058 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev)
port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
- if (!dp)
+ if (!port)
return -ENOMEM;
port->extcon = extcon;

ïark Yao

dri-devel mailing list

ïark Yao