Re: [PATCH] dma: k3dma: Fix non-cyclic mode

From: zhangfei
Date: Mon Jul 10 2017 - 21:16:54 EST




On 2017å07æ11æ 04:53, John Stultz wrote:
From: Antonio Borneo <borneo.antonio@xxxxxxxxx>

Commit 36387a2b1f62b5c087c5fe6f0f7b23b94f722ad7 ("k3dma: Fix
memory handling in preparation for cyclic mode") broke the
logic around ds_run/ds_done in case of non-cyclic DMA.

This went unnoticed as the only user of k3dma was the i2s
audio driver, but with a patch set to enable dma on SPI,
the issue cropped up.

This patch resolves the issue by reverting part of the
problematic commit.

This patch has been tested to ensure both audio playback and SPI
works fine using DMA and that no memory leak is present.

Cc: Vinod Koul <vinod.koul@xxxxxxxxx>
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Cc: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
Cc: dmaengine@xxxxxxxxxxxxxxx
Signed-off-by: Antonio Borneo <borneo.antonio@xxxxxxxxx>
[jstultz: Expanded commit message a bit]
Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>

Acked-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>

Thanks