Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable()

From: Michal Hocko
Date: Tue Jul 11 2017 - 03:22:31 EST


On Tue 11-07-17 09:16:12, Michal Hocko wrote:
> On Tue 11-07-17 08:56:04, Vlastimil Babka wrote:
[...]
> > It doesn't explain why it's redundant, indeed. Unfortunately, the commit
> > f106af4e90ea ("fix checks for expand-in-place mremap") which added this,
> > also doesn't explain why it's needed.
>
> Because it doesn't do anything AFAICS.

Well, it does actually. I have missed security_mmap_addr hook.
--
Michal Hocko
SUSE Labs