Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable()
From: Anshuman Khandual
Date: Tue Jul 11 2017 - 07:13:49 EST
On 07/11/2017 12:46 PM, Michal Hocko wrote:
> On Tue 11-07-17 08:56:04, Vlastimil Babka wrote:
>> On 07/11/2017 08:50 AM, Michal Hocko wrote:
>>> On Tue 11-07-17 08:26:40, Vlastimil Babka wrote:
>>>> On 07/11/2017 08:03 AM, Michal Hocko wrote:
>>>>> Are you telling me that two if conditions cause more than a second
>>>>> difference? That sounds suspicious.
>>>> It's removing also a call to get_unmapped_area(), AFAICS. That means a
>>>> vma search?
>>> Ohh, right. I have somehow missed that. Is this removal intentional?
>> I think it is: "Checking for availability of virtual address range at
>> the end of the VMA for the incremental size is also reduntant at this
> I though this referred to this check
> if (vma->vm_next && vma->vm_next->vm_start < end)
No, that check is still there in the code.