Re: [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124

From: Marcel Ziswiler
Date: Tue Jul 11 2017 - 10:54:29 EST


On Tue, 2017-07-11 at 11:50 +0300, Paul Kocialkowski wrote:
> On Sun, 2017-07-09 at 19:36 +0300, Paul Kocialkowski wrote:
> > This registers the host1x node with the SMMU (as HC swgroup) to
> > allow
> > the host1x code to attach to it. It avoid failing the probe
> > sequence,
> > which resulted in the tegra drm driver not probing and thus nothing
> > being displayed on-screen.
>
> Fixes: 404bfb78daf3 ("gpu: host1x: Add IOMMU support")
>
> > Signed-off-by: Paul Kocialkowski <contact-
> > W9ppeneeCTY@xxxxxxxxxxxxxxxx>

Tested-by:ÂMarcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
Tested-on: Apalis TK1, Jetson-TK1

> > ---
> > Âarch/arm/boot/dts/tegra124.dtsi | 1 +
> > Â1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/tegra124.dtsi
> > b/arch/arm/boot/dts/tegra124.dtsi
> > index 187a36c6d0fc..b3b89befffeb 100644
> > --- a/arch/arm/boot/dts/tegra124.dtsi
> > +++ b/arch/arm/boot/dts/tegra124.dtsi
> > @@ -85,6 +85,7 @@
> > Â clocks = <&tegra_car TEGRA124_CLK_HOST1X>;
> > Â resets = <&tegra_car 28>;
> > Â reset-names = "host1x";
> > + iommus = <&mc TEGRA_SWGROUP_HC>;
> > Â
> > Â #address-cells = <2>;
> > Â #size-cells = <2>;

So I take it we still will need this one moving forward, correct?

How about tegra30, I guess the same applies there, isn't it? Should I
send a patch or are you guys doing that?