Re: [PATCH 3/3] PCI: hotplug: constify attribute_group structures.

From: Tyrel Datwyler
Date: Tue Jul 11 2017 - 14:55:53 EST


On 07/11/2017 02:28 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 418 160 8 586 24a drivers/pci/hotplug/rpadlpar_sysfs.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 482 96 8 586 232 drivers/pci/hotplug/rpadlpar_sysfs.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>

Reviewed-by: Tyrel Datwyler <tyreld@xxxxxxxxxxxxxxxxxx>