Re: [PATCH v4 1/1] ARM: dts: imx53: Add GE Healthcare PPD

[Fabio Estevam]

On Wed, Jul 12, 2017 at 9:32 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> On Tue, Jul 11, 2017 at 10:42 AM, Martyn Welch
> <martyn.welch@xxxxxxxxxxxxxxx> wrote:
>
>> Changes since PATCHv3: https://patchwork.kernel.org/patch/9819017/
>>  - licensing modified
>>  - manufacturer changed to GE
>>  - regulator nodes corrected
>>  - backlight node corrected
>>  - flags rather than magic numbers used
>>  - registers for usbphys added
>>  - set up IOMUX configuration correctly
>>  - various whitespace corrections
>>  - removed unused fsl,mode node
>
> Actually I still see 'fsl,mode' under the ssi2 node. Please remove it.
>
>> +#define I2C_PAD_CTL 0xc0000000
>
> This still sets bits 31, which means the kernel will rely on the IOMUX
> configuration from the bootloader.
>
> It is better if you could just pass the real IOMUX values here instead.

And please also fix the typo on the
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx address next time :-)