Re: [PATCH 1/2] ACPI: EC: Drop EC noirq hooks to fix a regression

From: Rafael J. Wysocki
Date: Wed Jul 12 2017 - 17:25:40 EST


On Wednesday, July 12, 2017 11:09:09 AM Lv Zheng wrote:
> According to the bug report, though the busy polling mode can make noirq
> stages executed faster, it causes abnormal fan blowing up after a system
> resume (see link #1 for a video demonstration) on Lenovo ThinkPad X1 Carbon
> - the 5th Generation. The problem can be fixed by an upgraded EC firmware.
>
> However many reporters can also confirm that the problem can be fixed by
> stopping busy polling during suspend/resume.
>
> This patch drops noirq stage hooks so that the regression can be fixed
> without upgrading the EC firmware.
>
> Fixes: c3a696b6e8f8 ("ACPI / EC: Use busy polling mode when GPE is not enabled")
> Link: https://youtu.be/9NQ9x-Jm99Q [#1]
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=196129
> Reported-by: Andreas Lindhe <andreas@xxxxxxxxx>
> Tested-by: Gjorgji Jankovski <j.gjorgji@xxxxxxxxx>
> Tested-by: Damjan Georgievski <gdamjan@xxxxxxxxx>
> Tested-by: Fernando Chaves <nanochaves@xxxxxxxxx>
> Tested-by: Tomislav Ivek <tomislav.ivek@xxxxxxxxx>
> Tested-by: Denis P. <theoriginal.skullburner@xxxxxxxxx>
> Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
> Cc: Stable <stable@xxxxxxxxxxxxxxx> # all applicable

Both patches applied with some minor modifications in the changelogs.

Thanks,
Rafael