Re: Regression during 4.13 merge window: Mouse not working (under X)

From: Olof Johansson
Date: Wed Jul 12 2017 - 20:08:48 EST

On Wed, Jul 12, 2017 at 2:55 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Wed, Jul 12, 2017 at 02:45:18PM -0700, Olof Johansson wrote:
>> Dmitry,
>> I installed current mainline (as of 3b06b1a744) on a z840 here, and
>> lost the mouse.
>> Bisecting down, it seems like "HID: usbhid: remove custom locking from
>> usbhid_open/close" (e399396a6b0) is at fault, and if I revert that and
>> 283a21da1239 I get a working system again. Userspace is Ubuntu 16.04.
> Olof, does the patch below work for you?

Yup! Thanks!

> --
> Dmitry
> HID: usbhid: fix "always poll" quirk
> From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Even though the IO for devices with "always poll" quirk is already running,
> we still need to set HID_OPENED bit in usbhid->iofl so the interrupt
> handler does not ignore the data coming from the device.
> Reported-by: Olof Johansson <olof@xxxxxxxxx>
> Fixes: e399396a6b0 ("HID: usbhid: remove custom locking from usbhid_open...")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Tested-by: Olof Johansson <olof@xxxxxxxxx>