Re: [PATCH 08/17] tty: New RISC-V SBI console driver

[Michael Ellerman]

Palmer Dabbelt <palmer@xxxxxxxxxxx> writes:

> On Wed, 12 Jul 2017 04:04:00 PDT (-0700), mpe@xxxxxxxxxxxxxx wrote:
>> Palmer Dabbelt <palmer@xxxxxxxxxxx> writes:
>>
>>> On Mon, 10 Jul 2017 23:21:07 PDT (-0700), mpe@xxxxxxxxxxxxxx wrote:
>>>> Palmer Dabbelt <palmer@xxxxxxxxxxx> writes:
>>>>>
>>>> ...
>>>>> +#ifdef CONFIG_EARLY_PRINTK
>>>>> +static void sbi_console_write(struct console *co, const char *buf,
>>>>> +			      unsigned int n)
>>>>> +{
>>>>> +	int i;
>>>>> +
>>>>> +	for (i = 0; i < n; ++i) {
>>>>> +		if (buf[i] == '\n')
>>>>> +			sbi_console_putchar('\r');
>>>>> +		sbi_console_putchar(buf[i]);
>>>>> +	}
>>>>> +}
>>>>> +
>>>>> +static struct console early_console_dev __initdata = {
>>>>> +	.name	= "early",
>>>>> +	.write	= sbi_console_write,
>>>>> +	.flags	= CON_PRINTBUFFER | CON_BOOT,
>>>>
>>>> AFAICS you could add CON_ANYTIME here, which would mean this console
>>>> would print output before the CPU is online.
>>>>
>>>> I think it doesn't currently matter because you call parse_early_param()
>>>> from setup_arch(), at which point the boot CPU has been marked online.
>>>>
>>>> But if this console can actually work earlier then you might be better
>>>> off just registering it unconditionally very early.
>>>
>>> That seems like a good idea.  I'm not familiar with how all this works, but
>>> from my understanding of this early_initcall() should be sufficient to make
>>> this work?  The only other driver that sets CON_ANYTIME and supports
>>> EARLY_PRINTK is hvc_xen, but that installs a header to let init code register
>>> the console directly.  The early_initcall mechanism seems cleaner if it does
>>> the right thing.
>>
>> Unfortunately early_initcall is not very "early" :)  It's earlier than
>> all the other initcalls, but it's late compared to most of the arch boot
>> code.
>>
>> The early_param() will work better, ie. register the console earlier
>> and increase the chance of you getting output from an early crash, than
>> early_initcall. But it requires you to put earlyprintk on the command line.
>>
>> The best option is to just register the console as early as you can, ie.
>> as soon as it can give you output. So somewhere in your setup_arch(), or
>> even earlier (I haven't read your boot code).
>
> Doing it that way would require either moving the TTY driver into arch code (it
> was specifically suggested we move it out) or adding a header file to allow
> setup_arch() to call into the driver (XEN does this, and we're doing it for our
> timer, but it seems hacky).

I think it's fairly uncontroversial to have the early console in arch
code, especially in a case like this where there's no code shared
between the console and the TTY driver. But maybe someone will prove me
wrong.

Doing it the other way is not really hacky IMO, you can just have an
extern for the early console in one of your asm headers.

But anyway none of that is really that important so I'll shuddup :)

cheers