Re: [PATCH 3/4] perf annotate: Support --show-nr-samples option

[Taeung Song]

On 07/13/2017 05:13 AM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 12, 2017 at 07:14:14AM +0900, Taeung Song escreveu:
> > Add --show-nr-samples option to perf-annotate
> > so that it corresponds with perf-report.
> > Additionally h->sum is properly renamed h->nr_samples.
>
> Please first do a patch renaming ->sum to ->nr_samples, then a patch
> supportign --show-nr-samples.
>
> We can have this new --show-nr-samples option, but perhaps the best way
> would be to have a hotkey (I guess we have for period, right) for this?

You mean we need to add a hotkey for --show-nr-samples on the anntoate 
TUI browser,
right ? I added a 'e' hotkey in other patch, not this patch
Change it ?

> At some point would be good to have some 'S' or other hotkey to save the > current set of output modifiers (nr-samples column, period column, etc)
> in the .perfconfig file.

I don't understand what you said..
Is related a hotkey with things in .perfconfig file ?
I thought hotkeys exist on only annotate TUI browser..
You mean the short option for --show-nr-samples ?

Thanks,
Taeung

> - Arnaldo


SNIP