Re: [PATCH v7 3/3] net/cxgb4: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag
From: Alexander Duyck
Date: Thu Jul 13 2017 - 14:17:39 EST
On Thu, Jul 13, 2017 at 11:14 AM, Alexander Duyck
> On Thu, Jul 13, 2017 at 7:21 AM, Ding Tianhong <dingtianhong@xxxxxxxxxx> wrote:
>> From: Casey Leedom <leedom@xxxxxxxxxxx>
>> cxgb4 Ethernet driver now queries PCIe configuration space to determine
>> if it can send TLPs to it with the Relaxed Ordering Attribute set.
>> Remove the enable_pcie_relaxed_ordering() to avoid enable PCIe Capability
>> Device Control[Relaxed Ordering Enable] at probe routine, to make sure
>> the driver will not send the Relaxed Ordering TLPs to the Root Complex which
>> could not deal the Relaxed Ordering TLPs.
>> Signed-off-by: Casey Leedom <leedom@xxxxxxxxxxx>
>> Signed-off-by: Ding Tianhong <dingtianhong@xxxxxxxxxx>
> You can probably just drop this patch. If I am understanding Casey
> correctly just the fact that the relaxed ordering enable bit is
> cleared in the configuration should be enough to do this for the
> device automatically.
> - Alex
Actually I take that back. I hadn't caught the most recent parts of
the thread. If this is good for Casey then this works for me.