Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev
From: Moritz Fischer
Date: Thu Jul 13 2017 - 23:36:36 EST
On Thu, Jul 13, 2017 at 6:34 PM, Andrew Lunn <andrew@xxxxxxx> wrote:
>> > > + /* not sure if this is the correct way of dealing with this ... */
>> > > + ndev->phydev->supported &= ~(SUPPORTED_Autoneg);
>> > > + ndev->phydev->advertising = ndev->phydev->supported;
>> > > + ndev->phydev->autoneg = AUTONEG_DISABLE;
>> > What are you trying to achieve?
>> Basically can't do Autoneg, I'll need to take a closer look.
> Hi Moritz
> What i actually think you mean, is it can only do 1Gbps. So you could
> autoneg, but only advertise 1Gbps. Look at masking out
> PHY_10BT_FEATURES and PHY_100BT_FEATURES.
It does either 1Gbps or 10Gbps (over SFP+), depending which bitstream is loaded
into the FPGA. In the current setup I could also just have two
strings, since neither setup supports the other rate, but that might change.
It seems getting rid of that part (the default values) now works, too.
I'll need to take a closer look tomorrow (and I need to retest with 1Gbps)
> Take a look at:
Thanks for feedback,