Re: [PATCH] PM / Domains: defer dev_pm_domain_set() until genpd->attach_dev succeeds if present

[Sudeep Holla]

On 12/07/17 17:36, Sudeep Holla wrote:
> 
> 
> On 12/07/17 14:59, Ulf Hansson wrote:
>> On 29 June 2017 at 20:00, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
>>> If the genpd->attach_dev or genpd->power_on fails, genpd_dev_pm_attach
>>> may return -EPROBE_DEFER initially. However genpd_alloc_dev_data sets
>>> the PM domain for the device unconditionally.
>>>
>>> When subsequent attempts are made to call genpd_dev_pm_attach, it may
>>> return -EEXISTS checking dev->pm_domain without re-attempting to call
>>> attach_dev or power_on.
>>>
>>> platform_drv_probe then attempts to call drv->probe as the return value
>>> -EEXIST != -EPROBE_DEFER, which may end up in a situation where the
>>> device is accessed without it's power domain switched on.
>>
>> Right, this makes sense.
>>
> 
> Thanks
> 
>>>
>>> Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
>>> Cc: Kevin Hilman <khilman@xxxxxxxxxx>
>>> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>>> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
>>
>> Could we perhaps work out which commit it fixes, or perhaps the
>> problem been there long time ago and we should just add a stable tag?
>>
> 
> OK I will dig that out.
> 

It looks like commit 989561de9b51 ("PM / Domains: add setter for
dev.pm_domain") added the helper. I then follow it to commit
f104e1e5ef57 ("PM / Domains: Re-order initialization of
generic_pm_domain_data"). The code in the original commit 6ff7bb0d02f8
("PM / Domains: Cache device stop and domain power off governor results,
v3") looks OK to me.

So What should I do ? Add
Fixes: f104e1e5ef57 ("PM / Domains: Re-order initialization of
generic_pm_domain_data")

tag in the mainline. And when Greg or others fix up before v4.4, I need
to work out the fix for that stable version ?

-- 
Regards,
Sudeep