Re: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool

From: Dan Carpenter
Date: Fri Jul 14 2017 - 08:07:31 EST


- if (!frob()) {
+ if (frob() == 0) {

is a totally pointless change. They're both bad, because they're doing
success testing instead of failure testing, but probably the second one
is slightly worse.

This warning seems dumb. I can't imagine it has even a 10% success rate
at finding real bugs. Just disable it.

Changing the code to propagate error codes, is the right thing of course
so long as it doesn't introduce bugs.

dan carpenter